Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qualx app metrics #1102

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix qualx app metrics #1102

merged 3 commits into from
Jun 11, 2024

Conversation

leewyang
Copy link
Collaborator

From @eordentlich, this PR fixes per-app aggregations, specifically for QX (raw xgboost) metrics on datasets where the sqlIDs may be misaligned.

Changes

  1. defer GPU appDuration calculations to per-app aggregations post prediction vs. carrying per-sql pre-prediction.
  2. add scaleFactor to the per-app aggregations.
  3. add description to the appName when overridding descriptions to allow CPU/GPU joining.
  4. fix loading model by name.

Test

Following CMDs have been tested:

Internal Usage:

python qualx_main.py predict
python qualx_main.py evaluate

Signed-off-by: Lee Yang <leewyang@gmail.com>
…model load

Signed-off-by: Lee Yang <leewyang@gmail.com>
@amahussein amahussein added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Jun 10, 2024
Signed-off-by: Lee Yang <leewyang@gmail.com>
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leewyang

@amahussein amahussein merged commit c0b0ded into NVIDIA:dev Jun 11, 2024
15 checks passed
@leewyang leewyang deleted the qualx_app_metrics branch June 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants