Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nan label issue in training #1104

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix nan label issue in training #1104

merged 1 commit into from
Jun 11, 2024

Conversation

leewyang
Copy link
Collaborator

This PR fixes a regression in training introduced in #1102.

Changes

  1. Add back code to remove rows w/ NaN labels (but relocated inside the train() method).

Test

Following CMDs have been tested:

Internal Usage:

python qualx_main.py preprocess
python qualx_main.py predict
python qualx_main.py train
python qualx_main.py evaluate
python qualx_main.py compare

@leewyang
fix nan label issue in training
16a96c6 
Signed-off-by: Lee Yang <leewyang@gmail.com>
@parthosa parthosa added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Jun 11, 2024
@parthosa parthosa changed the title fix nan label issue in training Fix nan label issue in training Jun 11, 2024
parthosa
parthosa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leewyang

@leewyang leewyang merged commit 7699d3c into NVIDIA:dev Jun 11, 2024
16 checks passed
@leewyang leewyang deleted the qualx_fix_train branch June 11, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@amahussein amahussein Awaiting requested review from amahussein

Assignees

@leewyang leewyang

Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leewyang @parthosa