Add Decimal 128 as a supported type in partition by for databricks ru…

…nning window [databricks] (#4953) * fix window rank integration tests on databricks Signed-off-by: Navin Kumar <navink@nvidia.com> * enable these tests but turn databricks + Decimal128 into an xfail test Signed-off-by: Navin Kumar <navink@nvidia.com> * Add reference to bug, and update copy Signed-off-by: Navin Kumar <navink@nvidia.com> * Add Decimal 128 support to partition by in Databricks running window equivalent Signed-off-by: Navin Kumar <navink@nvidia.com> * Remove xfail for running window tests on databricks Signed-off-by: Navin Kumar <navink@nvidia.com> * Remove unused import Signed-off-by: Navin Kumar <navink@nvidia.com>
NVIDIA · Mar 15, 2022 · ffec760 · ffec760
1 parent 91a2e3a
commit ffec760
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sql-plugin/src/main/301db/scala/com/nvidia/spark/rapids/shims/Spark30XdbShims.scala b/sql-plugin/src/main/301db/scala/com/nvidia/spark/rapids/shims/Spark30XdbShims.scala
@@ -134,7 +134,7 @@ abstract class Spark30XdbShims extends Spark30XdbShimsBase with Logging {
             TypeSig.STRUCT + TypeSig.ARRAY + TypeSig.MAP).nested(),
           TypeSig.all,
           Map("partitionSpec" ->
-              InputCheck(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_64,
+              InputCheck(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_128,
                 TypeSig.all))),
         (runningWindowFunctionExec, conf, p, r) =>
           new GpuRunningWindowExecMeta(runningWindowFunctionExec, conf, p, r)

diff --git a/sql-plugin/src/main/31xdb/scala/com/nvidia/spark/rapids/shims/Spark31XdbShims.scala b/sql-plugin/src/main/31xdb/scala/com/nvidia/spark/rapids/shims/Spark31XdbShims.scala
@@ -363,7 +363,7 @@ abstract class Spark31XdbShims extends Spark31XdbShimsBase with Logging {
             TypeSig.STRUCT + TypeSig.ARRAY + TypeSig.MAP).nested(),
           TypeSig.all,
           Map("partitionSpec" ->
-              InputCheck(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_64,
+              InputCheck(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_128,
                 TypeSig.all))),
           (runningWindowFunctionExec, conf, p, r) =>
             new GpuRunningWindowExecMeta(runningWindowFunctionExec, conf, p, r)