Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decimal 128 as a supported type in partition by for databricks running window [databricks] #4953

Conversation

NVnavkumar
Copy link
Collaborator

Fixes #4936.

This resolves the issue with Decimal 128 and Databricks by updating the type check to support Decimal 128 in the Databricks class for running window computation.

Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
…equivalent

Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
@NVnavkumar NVnavkumar requested review from revans2 and tgravescs March 15, 2022 00:19
@NVnavkumar
Copy link
Collaborator Author

build

Signed-off-by: Navin Kumar <navink@nvidia.com>
@sameerz sameerz added the bug Something isn't working label Mar 15, 2022
@sameerz sameerz added this to the Feb 28 - Mar 18 milestone Mar 15, 2022
@NVnavkumar NVnavkumar marked this pull request as draft March 15, 2022 02:19
@NVnavkumar
Copy link
Collaborator Author

build

@jlowe
Copy link
Member

jlowe commented Mar 15, 2022

[databricks] should be used as a suffix on a PR headline and not part of the headline description, as these annotations are stripped from the summary when the changelog is generated.

@NVnavkumar NVnavkumar changed the title Add Decimal 128 as a supported type in partition by for [databricks] running window Add Decimal 128 as a supported type in partition by for databricks running window [databricks] Mar 15, 2022
@NVnavkumar NVnavkumar marked this pull request as ready for review March 15, 2022 16:46
@NVnavkumar NVnavkumar self-assigned this Mar 15, 2022
@NVnavkumar NVnavkumar merged commit ffec760 into NVIDIA:branch-22.04 Mar 15, 2022
@NVnavkumar NVnavkumar deleted the databricks_running_window_decimal_128 branch March 15, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] databricks nightly window_function_test failures
3 participants