Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scala UDF compiler can decompile UDFs with RAPIDS implementation #1712

Closed
jlowe opened this issue Feb 11, 2021 · 2 comments · Fixed by #2523
Closed

[BUG] Scala UDF compiler can decompile UDFs with RAPIDS implementation #1712

jlowe opened this issue Feb 11, 2021 · 2 comments · Fixed by #2523
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jlowe
Copy link
Member

jlowe commented Feb 11, 2021

Now that Scala UDFs have support for a RAPIDS implementation since #1636, there's the possibility that the Scala UDF compiler could end up compiling a user's Scala UDF into Catalyst expressions despite the fact that it already provides a RAPIDS columnar implementation. The UDF compiler should detect and avoid trying to translate UDFs that implement the RapidsUDF interface.

@jlowe jlowe added bug Something isn't working good first issue Good for newcomers ? - Needs Triage Need team to review and classify labels Feb 11, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 16, 2021
@sameerz sameerz modified the milestone: Apr 26 - May 7 Apr 26, 2021
@GaryShen2008
Copy link
Collaborator

Remove from v21.06. Let's target in 21.08.

@jlowe
Copy link
Member Author

jlowe commented Jun 3, 2021

Fixed by #1712

@jlowe jlowe closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants