Not compile RapidsUDF when udf compiler is enabled #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
firestarman
reviewed
May 27, 2021
Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
revans2
previously approved these changes
May 27, 2021
|
build |
jlowe
requested changes
May 27, 2021
sameerz
added
the
task
Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
abellina
reviewed
Jun 2, 2021
jlowe
reviewed
Jun 2, 2021
Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
abellina
reviewed
Jun 2, 2021
jlowe
reviewed
Jun 2, 2021
Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
jlowe
approved these changes
Jun 2, 2021
|
build |
abellina
approved these changes
Jun 2, 2021
tgravescs
pushed a commit
that referenced
this pull request
Jun 9, 2021
* Not compile RapidsUDF when udf compiler is enabled Signed-off-by: Allen Xu <wjxiz1992@gmail.com> * add empty line back Signed-off-by: Allen Xu <wjxiz1992@gmail.com> * Use reflection for Java UDF Signed-off-by: Allen Xu <wjxiz1992@gmail.com> * resolve comments Signed-off-by: Allen Xu <wjxiz1992@gmail.com> * Code clean Signed-off-by: Allen Xu <wjxiz1992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close: #1712.
Originally, when UDF Compiler is enabled, it will always try to compile the bytecodes for any instance of a ScalaUDF.
This PR detects if a ScalaUDF implements the RapidsUDF interface. If yes, don't compile its bytecode because user has already provided a columnar evaluation method for the function.
Signed-off-by: Allen Xu wjxiz1992@gmail.com