Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TypeChecks diagnostics outputs column ids instead of unsupported types #2320

Closed
gerashegalov opened this issue May 1, 2021 · 0 comments · Fixed by #2321
Closed

[BUG] TypeChecks diagnostics outputs column ids instead of unsupported types #2320

gerashegalov opened this issue May 1, 2021 · 0 comments · Fixed by #2321
Assignees
@gerashegalov
Labels
bug Something isn't working

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug
TypeCheck warnings report column names without the type info, e.g.,

!Exec cannot run on GPU because Nested types in grouping expressions are not supported; unsupported data types in input: a#0; unsupported data types in output: a#0

Steps/Code to reproduce bug
Any query with an unsupported type involved e.g. #2274

Expected behavior

!Exec cannot run on GPU because Nested types in grouping expressions are not supported; unsupported data types in input: StructType(StructField(a,IntegerType,true), StructField(b,IntegerType,true)); unsupported data types in output: StructType(StructField(a,IntegerType,true), StructField(b,IntegerType,true))

Environment details (please complete the following information)
reproduces locally

Additional context
Uncovered in #2274 , broken by 64f9d9b#diff-c5cb89e178628729e961e2e0e9be2689893254638c5ce467250a263f7867112dR558
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 1, 2021
@gerashegalov gerashegalov removed the ? - Needs Triage Need team to review and classify label May 1, 2021
@gerashegalov gerashegalov self-assigned this May 1, 2021
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue May 1, 2021
@gerashegalov
Restore output of unsupport column types
422df2d 
Fixes NVIDIA#2320
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue May 1, 2021
@gerashegalov
Restore output of unsupport column types
5a9aabc 
Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov mentioned this issue May 1, 2021
Merged
jlowe pushed a commit that referenced this issue May 3, 2021
@gerashegalov
Restore output of unsupported column types (#2321)
707fd8d 
* Restore output of unsupport column types

Fixes #2320

Signed-off-by: Gera Shegalov <gera@apache.org>

* attribute references grouped by type

* original messages

* expression id
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Restore output of unsupported column types (NVIDIA#2321)
92471e4 
* Restore output of unsupport column types

Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>

* attribute references grouped by type

* original messages

* expression id
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Restore output of unsupported column types (NVIDIA#2321)
bd8f761 
* Restore output of unsupport column types

Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>

* attribute references grouped by type

* original messages

* expression id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore output of unsupported column types gerashegalov/spark-rapids
1 participant
@gerashegalov