Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore output of unsupported column types #2321

Merged
merged 4 commits into from
May 3, 2021
Merged

Restore output of unsupported column types #2321

merged 4 commits into from
May 3, 2021

Conversation

gerashegalov
Copy link
Collaborator

Fixes #2320

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Restore output of unsupport column types
5a9aabc 
Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov requested a review from jlowe May 1, 2021 09:57
@gerashegalov gerashegalov self-assigned this May 1, 2021
@gerashegalov gerashegalov added the bug Something isn't working label May 1, 2021
@gerashegalov gerashegalov added this to the Apr 26 - May 7 milestone May 1, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator Author

New output:

!Exec <HashAggregateExec> cannot run on GPU because unsupported data types in output: StructType(StructField(a,IntegerType,true), StructField(b,IntegerType,true)) [a#0]; unsupported data types in input: StructType(StructField(a,IntegerType,true), StructField(b,IntegerType,true)) [a#0]; Nested types in grouping expressions are not supported

@gerashegalov
Copy link
Collaborator Author

build

revans2
revans2 approved these changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this.

@jlowe jlowe merged commit 707fd8d into NVIDIA:branch-0.6 May 3, 2021
@gerashegalov gerashegalov deleted the fixTypeCheckDiagnostics branch May 3, 2021 23:17
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Restore output of unsupported column types (NVIDIA#2321)
92471e4 
* Restore output of unsupport column types

Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>

* attribute references grouped by type

* original messages

* expression id
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Restore output of unsupported column types (NVIDIA#2321)
bd8f761 
* Restore output of unsupport column types

Fixes NVIDIA#2320

Signed-off-by: Gera Shegalov <gera@apache.org>

* attribute references grouped by type

* original messages

* expression id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working
Projects
None yet
Milestone
Apr 26 - May 7
Development

Successfully merging this pull request may close these issues.

[BUG] TypeChecks diagnostics outputs column ids instead of unsupported types
3 participants
@gerashegalov @jlowe @revans2