Use improved CUDF JSON validation #11464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
|
build |
abellina
reviewed
Sep 17, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@abellina please take another look |
abellina
previously approved these changes
Sep 17, 2024
|
build |
ttnghia
previously approved these changes
Sep 17, 2024
|
build |
|
@abellina please take another look. My changes to the text buffering accidentally filtered out too much for hive text files and our tests caught it. I made the change so it is now specific to JSON and added a test file to verify that the case when all of the lines are bogus or empty works as expected. |
abellina
reviewed
Sep 17, 2024
| override def createBufferer(estimatedSize: Long, | ||
| lineSeparatorInRead: Array[Byte]): HostLineBufferer = | ||
| new HostLineBufferer(estimatedSize, lineSeparatorInRead) | ||
| new HostLineBufferer(estimatedSize, lineSeparatorInRead, true) | ||
| } | ||
|
|
||
| /** | ||
| * Buffer the lines in a single HostMemoryBuffer with the separator inserted inbetween each of | ||
| * the lines. |
There was a problem hiding this comment.
nit, could you add a comment that HostLineBufferer is used for JSON and one for HostStringColBufferer that should be used for other formats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on rapidsai/cudf#15968 that was merged in recently
This fixes #10457
This fixes #10479
This fixes #10534
This fixes #10911
It also fixes some issue with JSON scan where if all of the input is invalid/empty lines before it would error out, but now our work around fixes that. It is not a final solution though.