JSON reader validation of values #15968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
feature request
github-actions
bot
added
libcudf
karthikeyann
changed the title
…_spark_validation
…_spark_validation
* change device_uvector to device_buffer * update tests --------- Co-authored-by: Karthikeyan Natarajan <karthikeyann@users.noreply.github.com>
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
ttnghia
reviewed
Sep 9, 2024
Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com>
Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com>
mythrocks
approved these changes
Sep 10, 2024
ttnghia
reviewed
Sep 10, 2024
ttnghia
approved these changes
Sep 10, 2024
revans2
requested changes
Sep 10, 2024
| @@ -1683,6 +1696,10 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_Table_readAndInferJSON(JNIEnv* env, | |||
| .recovery_mode(recovery_mode) | |||
| .normalize_single_quotes(static_cast<bool>(normalize_single_quotes)) | |||
| .normalize_whitespace(static_cast<bool>(normalize_whitespace)) | |||
| .strict_validation(strict_validation) | |||
There was a problem hiding this comment.
This code has to change now for the tests to pass. We have to not try and set
.numeric_leading_zeros(allow_leading_zeros)
.nonnumeric_numbers(allow_nonnumeric_numbers)
.unquoted_control_chars(allow_unquoted_control)
at all if strict_validation is disabled. And this goes for all of the APIs in this file because of the assertion that was just added in.
ttnghia
approved these changes
Sep 10, 2024
karthikeyann
commented
Sep 10, 2024
revans2
approved these changes
Sep 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses part of #15222
This change adds validation stage in JSON reader at tokens level. If any validation fails in a row, it will make the entire row as null.
thrust::tabulate_output_iteratorNVIDIA/cccl#2282)Checklist