skip test_window_aggs_for_rows_lead_lag_on_arrays #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some rows of order-by columns (it's `a,b,c` in the test) are equal, then it may fail because CPU and GPU can't guarantee the order for the same rows, while lead/lag is typically depending on row's order. The solution is we should add the aggregation column `d` and the default column `d_default` columns into the order-by to guarantee the order. But for now, sorting on array has not been supported yet, see NVIDIA#2470. So this PR just skip the test Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
pxLi
approved these changes
May 21, 2021
|
So fix this test instead of skipping it! There are ways to generate data that has no ambiguity in the order. |
This was referenced May 21, 2021
Closed
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
If some rows of order-by columns (it's `a,b,c` in the test) are equal, then it may fail because CPU and GPU can't guarantee the order for the same rows, while lead/lag is typically depending on row's order. The solution is we should add the aggregation column `d` and the default column `d_default` columns into the order-by to guarantee the order. But for now, sorting on array has not been supported yet, see NVIDIA#2470. So this PR just skip the test Signed-off-by: Bobby Wang <wbo4958@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
If some rows of order-by columns (it's `a,b,c` in the test) are equal, then it may fail because CPU and GPU can't guarantee the order for the same rows, while lead/lag is typically depending on row's order. The solution is we should add the aggregation column `d` and the default column `d_default` columns into the order-by to guarantee the order. But for now, sorting on array has not been supported yet, see NVIDIA#2470. So this PR just skip the test Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some rows of order-by columns (it's
a,b,cin the test) are equal,then it may fail because CPU and GPU can't guarantee the order for the
same rows, while lead/lag is typically depending on row's order.
The solution is we should add the aggregation column
dand the default columnd_defaultcolumns into the order-by to guarantee the order. But for now,sorting on array has not been supported yet, see
#2470.
So this PR just skip the test
Signed-off-by: Bobby Wang wbo4958@gmail.com