Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip test_window_aggs_for_rows_lead_lag_on_arrays #2471

Merged
merged 1 commit into from
May 21, 2021
Merged

skip test_window_aggs_for_rows_lead_lag_on_arrays #2471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions integration_tests/src/main/python/window_function_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ def do_it(spark):

# lead and lag are supported for arrays, but the other window operations like min and max are not right now
# once they are all supported the tests should be combined.
@pytest.mark.skip(reason="If some rows of order-by columns (here is a,b,c) are equal, then it may fail because"
"CPU and GPU can't guarantee the order for the same rows, while lead/lag is typically"
"depending on row's order. The solution is we should add the d and d_default columns"
"into the order-by to guarantee the order. But for now, sorting on array has not been"
"supported yet, see https://github.com/NVIDIA/spark-rapids/issues/2470."
"Once the issue is resolved, we should remove skip mark")
@ignore_order(local=True)
@pytest.mark.parametrize('d_gen', lead_lag_array_data_gens, ids=meta_idfn('agg:'))
@pytest.mark.parametrize('c_gen', [long_gen], ids=meta_idfn('orderBy:'))
Expand Down