Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for sorting structs #2507

Merged
merged 3 commits into from
May 27, 2021

Conversation

gerashegalov
Copy link
Collaborator

Relates to #1607

Signed-off-by: Gera Shegalov gera@apache.org

Relates to NVIDIA#1607

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator Author

build

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the test cases added are a bit redundant, but I would rather have more coverage than less so I am fine with it.

@abellina abellina merged commit 1cd417e into NVIDIA:branch-21.06 May 27, 2021
@gerashegalov gerashegalov deleted the rangePartitioningTests branch May 27, 2021 16:44
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Improve test coverage for sorting structs

Relates to NVIDIA#1607

Signed-off-by: Gera Shegalov <gera@apache.org>

* cudf fix
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Improve test coverage for sorting structs

Relates to NVIDIA#1607

Signed-off-by: Gera Shegalov <gera@apache.org>

* cudf fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants