Support aggregation on NullType in RunningWindowExec #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mithun RK <mythrocks@gmail.com>
|
build |
|
Do we know if we need NullType support for 21.06? |
tgravescs
approved these changes
Jun 16, 2021
#2596 didn't ship in 21.06, so I think it should be alright for this to be left out of 21.06 as well. |
pxLi
reviewed
Jun 17, 2021
| @@ -105,7 +105,7 @@ class Spark301dbShims extends Spark301Shims { | |||
| "Databricks-specific window function exec, for \"running\" windows, " + | |||
| "i.e. (UNBOUNDED PRECEDING TO CURRENT ROW)", | |||
| ExecChecks( | |||
| TypeSig.commonCudfTypes + TypeSig.DECIMAL + | |||
| TypeSig.commonCudfTypes + TypeSig.DECIMAL + TypeSig.Null + | |||
There was a problem hiding this comment.
found a typo here. I will draft a fix
There was a problem hiding this comment.
Oh, yikes!
I noticed that when testing on Databricks 7.3. I honestly thought I'd fixed that already.
I can post a fix shortly.
There was a problem hiding this comment.
#2729 just post one, can you help take a look? thx~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715.
#2596 extended
WindowExec's meta to allow for aggregations onNullTypeinput. E.g.test_window_running()andtest_window_running_no_part()integration tests were added to exercise this path.#2596 did not include a change to enable
NullTypeaggregations in the Databricks Shims, causing thetest_window_running*()tests to fail.This commit should resolve the failure.
Signed-off-by: Mithun RK mythrocks@gmail.com