Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 301db-shim typecheck typo #2729

Merged
merged 1 commit into from
Jun 17, 2021
Merged

fix 301db-shim typecheck typo #2729

merged 1 commit into from
Jun 17, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jun 17, 2021 •
edited
Loading

Signed-off-by: Peixin Li pxli@nyu.edu

to fix a typo in #2722

shims/spark301db/Spark301dbShims.scala:108: value Null is not a member of object com.nvidia.spark.rapids.TypeSig

@pxLi
fix 301db-shim typecheck typo
af1f505 
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi added bug Something isn't working test Only impacts tests labels Jun 17, 2021
@pxLi pxLi mentioned this pull request Jun 17, 2021
Merged
@pxLi
Copy link
Collaborator Author

pxLi commented Jun 17, 2021

build

@pxLi pxLi requested a review from mythrocks June 17, 2021 04:10
@mythrocks
Copy link
Collaborator

Thanks, @pxLi. This turned up in #2722 testing. I'm not sure how it got missed in the diff.

👍

@mythrocks
Copy link
Collaborator

I'd better retest this on 7.3, just to be safe.

@mythrocks
Copy link
Collaborator

I'd better retest this on 7.3, just to be safe.

Ok, just confirmed that the fix is good, on Databricks 7.3.

@pxLi
Copy link
Collaborator Author

pxLi commented Jun 17, 2021 •
edited
Loading

@mythrocks sure, I am running a separate nightly test, passed. Waiting for pre-merge run

@pxLi pxLi merged commit cacb86d into NVIDIA:branch-21.08 Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxLi @mythrocks