GpuIf and GpuCoalesce support array and struct types #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
This PR depends on #2826 , so it is WIP now. |
firestarman
added
cudf_dependency
jlowe
previously approved these changes
Jun 29, 2021
| @@ -92,7 +92,7 @@ def test_nvl(data_gen): | |||
| 'nvl(a, {})'.format(null_lit))) | |||
|
|
|||
| #nvl is translated into a 2 param version of coalesce | |||
| @pytest.mark.parametrize('data_gen', all_gens, ids=idfn) | |||
| @pytest.mark.parametrize('data_gen', all_gens + all_single_nested_gens, ids=idfn) | |||
There was a problem hiding this comment.
Is all_single_nested_gens defined?
can we add struct_gens_sample for deeper nesting?
we are also enabling arrays¸ can we add their gens too?
There was a problem hiding this comment.
Yes, it is defined in PR #2826, on which this PR depends.
I will add deeper nesting if it is supported by PR rapidsai/cudf#8588 . But verification is required at first.
| @@ -1187,10 +1187,13 @@ object GpuOverrides { | |||
| expr[Coalesce] ( | |||
| "Returns the first non-null argument if exists. Otherwise, null", | |||
| ExprChecks.projectNotLambda( | |||
| TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL, TypeSig.all, | |||
| (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() + | |||
There was a problem hiding this comment.
nit: we can use _commonTypes for this common combination
| @@ -1187,10 +1187,13 @@ object GpuOverrides { | |||
| expr[Coalesce] ( | |||
| "Returns the first non-null argument if exists. Otherwise, null", | |||
| ExprChecks.projectNotLambda( | |||
| TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL, TypeSig.all, | |||
| (TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL).nested() + | |||
| TypeSig.ARRAY + TypeSig.STRUCT, | |||
There was a problem hiding this comment.
are we going to add arbitrary nesting in a follow-up?
There was a problem hiding this comment.
Yes, I will add deeper nesting if it is supported by PR rapidsai/cudf#8588 . But verification is required at first.
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
changed the title
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
changed the title
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
|
LGTM |
jlowe
reviewed
Jul 21, 2021
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
jlowe
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GpuIfandGpuCoalescesupport scalar of list and struct.closes #2398
Signed-off-by: Firestarman firestarmanllc@gmail.com