Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent function name and add backward compatibility support for premerge job [skip ci] #3312

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Fix inconsistent function name and add backward compatibility support for premerge job [skip ci] #3312

merged 2 commits into from
Aug 27, 2021

Conversation

zhanga5
Copy link
Contributor

@zhanga5 zhanga5 commented Aug 26, 2021

Test passed for both 21.10 & 21.08 branches in forked repository

@zhanga5
Fix inconsistent function name and add backward compatibility support…
d49488b 
… for premerge job

Signed-off-by: Alex Zhang <alex4zhang@gmail.com>
@zhanga5 zhanga5 linked an issue Aug 26, 2021 that may be closed by this pull request
[FEA] pre-merge jenkinsfile compatibility #3247
Closed
@zhanga5 zhanga5 marked this pull request as draft August 26, 2021 09:23
@pxLi pxLi changed the title Fix inconsistent function name and add backward compatibility support for premerge job Fix inconsistent function name and add backward compatibility support for premerge job [skip ci] Aug 26, 2021
@pxLi pxLi added the build Related to CI / CD or cleanly building label Aug 26, 2021
@zhanga5
Respect [skip ci] flag for stage of 'Determine Project Version'
475ee39 
Signed-off-by: Alex Zhang <alex4zhang@gmail.com>
@pxLi
Copy link
Collaborator

pxLi commented Aug 27, 2021

build

pxLi
pxLi approved these changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help create a dummy PR to test after merge, thx!

@zhanga5
Copy link
Contributor Author

zhanga5 commented Aug 27, 2021

Please help create a dummy PR to test after merge, thx!

got it. Thanks!

@pxLi pxLi marked this pull request as ready for review August 27, 2021 01:13
@pxLi pxLi merged commit ab1f649 into NVIDIA:branch-21.10 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] pre-merge jenkinsfile compatibility
2 participants
@zhanga5 @pxLi