Fallback to CPU when datasource v2 enables RuntimeFiltering #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
revans2
changed the title
revans2
previously approved these changes
Sep 13, 2021
| override def tagPlanForGpu(): Unit = { | ||
| // Only Scan with SupportsRuntimeFiltering can support DPP. | ||
| if (!p.runtimeFilters.isEmpty) { | ||
| willNotWorkOnGpu("The DPP has not been supported") |
There was a problem hiding this comment.
Can we update the comment to be a little more clear? Perhaps something like.
"Runtime filtering (DPP) on datasource V2 is not supported"
shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala
Show resolved
Hide resolved
|
build |
1 similar comment
|
build |
revans2
previously approved these changes
Sep 14, 2021
| GpuOrcScanBase.tagSupport(this) | ||
| // we are being overly cautious and that Orc does not support this yet | ||
| if (a.isInstanceOf[SupportsRuntimeFiltering]) { |
There was a problem hiding this comment.
here and elsewhere: Does calling tagSupport(this) on L542 make sense if this is true?
There was a problem hiding this comment.
Per my understanding. Plugin is trying best to explain all the reasons that won't run on GPU at a time.
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
wbo4958
force-pushed
the
batchscan-fallback
branch
from
a37a3ee to
ca072aa
Compare
|
build |
firestarman
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #3093