Ignore order for the test_no_fallback_when_ansi_enabled #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
jlowe
reviewed
Sep 22, 2021
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
|
No longer needed, since this PR had the same fix: #3330 |
tgravescs
approved these changes
Sep 23, 2021
|
Well your PR diff should be a no-op given this change (I think), but good to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Closes #3611
This was a dumb mistake that @razajafri found in #3330. As @jlowe nicely put it, yeah what I was trying to do is not deterministic given the hash tables involved (partitioning and in the group by), since I didn't have a sort after the operation.