Revert "Support int96RebaseModeInWrite and `int96RebaseModeInRead' (#3330)
#3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VIDIA#3330)" This reverts commit fc40c00.
revans2
approved these changes
Sep 23, 2021
|
build |
|
Note that Reza's commit had a fix for a test failure, I closed my PR for that test failure in favor of Reza's change. I'll reopen the other PR. |
|
FYI @tgravescs #3615 |
gerashegalov
approved these changes
Sep 23, 2021
|
Can we hold off on merging this? I may have the fix almost ready |
|
#3630 is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just get revert, no other changes. This commit is not up to date with the latest shim stuff and causes build failures in CDH and potentially others.
This reverts commit fc40c00.