Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default some configs to protect against cluster settings in integration tests #4917

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 8, 2022

Fixes #4893.

Sets up some configs to defaults in the integration tests to protect against cluster settings that could override the defaults and surprise tests that assume the defaults.

…on tests

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Mar 8, 2022
@jlowe jlowe added this to the Feb 28 - Mar 18 milestone Mar 8, 2022
@jlowe jlowe self-assigned this Mar 8, 2022
@jlowe
Copy link
Member Author

jlowe commented Mar 8, 2022

build

@jlowe jlowe merged commit b2a1ef8 into NVIDIA:branch-22.04 Mar 9, 2022
@jlowe jlowe deleted the test-defaults branch March 9, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration tests assume incompat config is false, we should verify this
2 participants