Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default some configs to protect against cluster settings in integration tests #4917

Merged
merged 1 commit into from
Mar 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion integration_tests/src/main/python/spark_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,29 @@ def _from_scala_map(scala_map):

# Default settings that should apply to CPU and GPU sessions.
# These settings can be overridden by specific tests if necessary.
_default_conf = { 'spark.sql.legacy.allowNegativeScaleOfDecimal': 'true' }
# Many of these are redundant with default settings for the configs but are set here explicitly
# to ensure any cluster settings do not interfere with tests that assume the defaults.
_default_conf = {
'spark.ansi.enabled': 'false',
'spark.rapids.sql.castDecimalToFloat.enabled': 'false',
'spark.rapids.sql.castDecimalToString.enabled': 'false',
'spark.rapids.sql.castFloatToDecimal.enabled': 'false',
'spark.rapids.sql.castFloatToIntegralTypes.enabled': 'false',
'spark.rapids.sql.castFloatToString.enabled': 'false',
'spark.rapids.sql.castStringToFloat.enabled': 'false',
'spark.rapids.sql.castStringToTimestamp.enabled': 'false',
'spark.rapids.sql.fast.sample': 'false',
'spark.rapids.sql.hasExtendedYearValues': 'true',
'spark.rapids.sql.hashOptimizeSort.enabled': 'false',
'spark.rapids.sql.hasNans': 'true',
'spark.rapids.sql.improvedFloatOps.enabled': 'false',
'spark.rapids.sql.improvedTimeOps.enabled': 'false',
'spark.rapids.sql.incompatibleDateFormats.enabled': 'false',
'spark.rapids.sql.incompatibleOps.enabled': 'false',
'spark.rapids.sql.mode': 'executeongpu',
'spark.rapids.sql.variableFloatAgg.enabled': 'false',
'spark.sql.legacy.allowNegativeScaleOfDecimal': 'true',
}

def is_tz_utc(spark=_spark):
"""
Expand Down