Skip to content

Commit

Permalink
pkp#6529 Fix author revision permissions with resubmit decision
Browse files Browse the repository at this point in the history
  • Loading branch information
@NateWr
NateWr committed Jan 5, 2021
1 parent 3777276 commit 50fc0bf
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
3 changes: 2 additions & 1 deletion classes/security/authorization/internal/SubmissionFileStageAccessPolicy.inc.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ function effect() {
foreach ($decisions as $decision) {
if ($decision['decision'] == SUBMISSION_EDITOR_DECISION_ACCEPT
|| $decision['decision'] == SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS
|| $decision['decision'] == SUBMISSION_EDITOR_DECISION_NEW_ROUND) {
|| $decision['decision'] == SUBMISSION_EDITOR_DECISION_NEW_ROUND
|| $decision['decision'] == SUBMISSION_EDITOR_DECISION_RESUBMIT) {
$assignedFileStages[] = $this->_fileStage;
break;
}
Expand Down
30 changes: 30 additions & 0 deletions locale/en_US/api.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,33 @@ msgstr "The public files directory was not found or files can not be saved to it

msgid "api.submissionFiles.400.assocTypeAndIdRequired"
msgstr "You can not modify the file association without passing an assocType and assocId."

msgid "api.submissionFiles.400.badDependentFileAssocType"
msgstr "You can not associate a file from this file stage with another submission file."

msgid "api.submissionFiles.400.badNoteAssocType"
msgstr "You can not associate a file from this file stage with discussion note."

msgid "api.submissionFiles.400.badReviewAssignmentAssocType"
msgstr "You can not associate a file from this file stage with a review assignment."

msgid "api.submissionFiles.400.badReviewRoundAssocType"
msgstr "You can not associate a file from this file stage with a review round."

msgid "api.submissionFiles.400.missingReviewRoundAssocType"
msgstr "You must specify a review round when requesting files in a review stage."

msgid "api.submissionFiles.400.noFileStageId"
msgstr "You must provide a file stage."

msgid "api.submissionFiles.400.reviewRoundSubmissionNotMatch"
msgstr "The review round you provided is not part of this submission."

msgid "api.submissionFiles.403.unauthorizedFileStageId"
msgstr "You are not allowed to access these files."

msgid "api.submissionFiles.403.unauthorizedFileStageIdWrite"
msgstr "You are not allowed to add and edit these files."

msgid "api.submissionFiles.403.unauthorizedReviewRound"
msgstr "You are not allowed to access files in this review round."

2 comments on commit 50fc0bf

@seisense
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the code in
classes/security/authorization/internal/SubmissionFileStageAccessPolicy.inc.php
But the code was at line no 96 not at 95 in my case in the above file.

In the other file
locale/en_US/api.po
There are a total of 54 lines in the file
What should I do?

@NateWr
Copy link
Owner Author

@NateWr NateWr commented on 50fc0bf Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit applies the fix to the master branch, which will be the next release. If you are using 3.2.1-2, you should apply the commit from the stable-3_2_1 branch: pkp@9a48ddb

Please sign in to comment.