Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author can not upload revisions when decision is to resubmit for review #6529

Closed
NateWr opened this issue Jan 5, 2021 · 6 comments
Closed
Assignees
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.

Comments

@NateWr
Copy link
Contributor

NateWr commented Jan 5, 2021

Describe the bug
When requesting revisions, the editor can choose whether or not the revisions will be subject to another round of review. If the editor chooses the resubmit for review option (SUBMISSION_EDITOR_DECISION_RESUBMIT), then the author will not have permission to upload revisions.

To Reproduce
Steps to reproduce the behavior:

  1. Create a submission and move it to the review stage.
  2. Click on Request Revisions, select resubmit for review, and save.
  3. Login as the author
  4. Click the Add File link in the revisions grid.
  5. See authorization error.

What application are you using?
3.2.1-2 and 3.3 RC2

Additional information
This bug was introduced with 3.2.1-2 as part of #6257. It also exists in 3.3RC2. Fixes are needed in both places.

See the forum report.

@NateWr NateWr added the Bug:3:Critical A bug that prevents a substantial minority of users from using the software. label Jan 5, 2021
@NateWr NateWr added this to the OJS/OMP/OPS 3.2.1-3 milestone Jan 5, 2021
@NateWr NateWr self-assigned this Jan 5, 2021
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jan 5, 2021
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jan 5, 2021
@NateWr
Copy link
Contributor Author

NateWr commented Jan 5, 2021

PRs:
#6531
#6530 (stable-3_2_1)

Tests:
pkp/ojs#2975
pkp/ojs#2974 (stable-3_2_1)

NateWr added a commit that referenced this issue Jan 5, 2021
#6529 Fix author revision permissions with resubmit decision
NateWr added a commit that referenced this issue Jan 5, 2021
#6529 Fix author revision permissions with resubmit decision
@NateWr
Copy link
Contributor Author

NateWr commented Jan 5, 2021

Merged to master and stable-3_2_1.

@NateWr NateWr closed this as completed Jan 5, 2021
@apacetech
Copy link

I am using Open Journal Systems 3.2.1.2 and I still facing same issue
image

Please help

@NateWr
Copy link
Contributor Author

NateWr commented Jan 11, 2021

This fix will not be available until 3.2.1-3 is out.

@jmvezic
Copy link

jmvezic commented Jan 19, 2021

@NateWr I think this might have been a bug only when the author also has a reviewer role when submitting the article. It doesn't show up in 3.2.1-2 for me when submitting only with the "author" role. In any case, glad it's fixed.

@jmvezic
Copy link

jmvezic commented Jan 19, 2021

@apacetech If you can't pull the fix from GitHub, you can follow these steps to circumvent the issue:.

  • Login as editor and go to the submission with this issue
  • Go to review, round 1
  • Click Request Revisions
  • Click "Revisions will not be subject to a new round of peer reviews" - this will nullify the previous new round decision
  • Inform the author they can now upload the new submission as "Revision"
  • After the author uploads the revision, manually add a new review round and choose the revision file to transfer to new round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Projects
None yet
Development

No branches or pull requests

3 participants