Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and synchronise the unit testing dependencies #4390

Closed
DimitarTachev opened this issue Feb 25, 2019 · 1 comment
Closed

Update and synchronise the unit testing dependencies #4390

DimitarTachev opened this issue Feb 25, 2019 · 1 comment
Assignees
Milestone

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We are using a hardcoded ("2.0.2") version of Karma (the latest one is 4.0.0), the latest versions of karma-{chosenFramework} and karma-nativescript-launcher

Describe the solution you'd like
We should either hardcode all of the versions or use the latest version of all dependencies.

dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this issue Mar 4, 2019
Workaround NativeScript/nativescript-cli#4390 by manually installing correct `karma-qunit`
@Fatme Fatme added this to the 5.2.1 milestone Mar 5, 2019
@DimitarTachev
Copy link
Contributor Author

DimitarTachev commented Mar 5, 2019

We will handle this by hardcoding the latest versions of the above-mentioned dependencies during npm prepack.

  • A json file with the hardcoded dependencies should be generated on prepack.
  • tns test init should read the generated file and add the specified versions to the project dev dependencies.
  • tns test init should throw an exception if the generated file is missing.

@rosen-vladimirov rosen-vladimirov modified the milestones: 5.2.1, 5.2.2 Mar 5, 2019
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this issue Mar 6, 2019
* fix: qunit tests

Workaround NativeScript/nativescript-cli#4390 by manually installing correct `karma-qunit`

* fix: enable commented tests

* refactor: migrate to TnsRunTest

* chore: remove hacks to handle qunit

* fix: unused imports
@endarova endarova closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants