Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base tests for test command on TnsRunTest #66

Merged
merged 5 commits into from
Mar 6, 2019
Merged

fix: base tests for test command on TnsRunTest #66

merged 5 commits into from
Mar 6, 2019

Conversation

dtopuzov
Copy link
Contributor

@dtopuzov dtopuzov commented Mar 4, 2019 •
edited
Loading

Refactoring:

  • Base tests on TnsRunTest

Fix:

  • Execute tests on Windows (there where no executed previously because of issue with tests with --justlauch on Windows).

@dtopuzov
fix: qunit tests
71e66f3 
Workaround NativeScript/nativescript-cli#4390 by manually installing correct `karma-qunit`
@cla-bot cla-bot bot added the cla: yes label Mar 4, 2019
@dtopuzov dtopuzov changed the title fix: qunit tests fix: base tests for test command on TnsRunTest Mar 5, 2019
@dtopuzov dtopuzov merged commit d325f13 into master Mar 6, 2019
@dtopuzov dtopuzov deleted the fix-qunit branch March 7, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endarova endarova endarova approved these changes

@miroslavaivanova miroslavaivanova Awaiting requested review from miroslavaivanova

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtopuzov @endarova