Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix netex as namespace of DistributionGroupRef #449

Merged
merged 22 commits into from
Feb 19, 2024

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Jun 16, 2023

Fix #448

@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Jun 16, 2023
@skinkie skinkie self-assigned this Jun 16, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Jun 16, 2023

@ue71603 can you take a peak how to make the examples working?

@ue71603
Copy link
Contributor

ue71603 commented Jun 17, 2023

@skinkie I think the part iabout the DistributionGroupRef is not needed as DistributionGroupRef is a restriction of the GeneralGroupOfEntitiesRefStructure
</xsd:element> <xsd:element name="DistributionGroupRef" minOccurs="0"> <xsd:annotation> <xsd:documentation>Prefined Group of specified points to which distribution is restricted, if any.</xsd:documentation> </xsd:annotation> <xsd:complexType> <xsd:simpleContent> <xsd:restriction base="GeneralGroupOfEntitiesRefStructure"> <xsd:attribute name="nameOfMemberClass"

What do you think?
The other occasions with a | are only related by SubstitutionGroup

@skinkie
Copy link
Contributor Author

skinkie commented Jun 17, 2023

I think we should have at least one example that actually is using a DistributionGroupRef. It is obviously that since we started fixing the constraints these issues popped up.

@ue71603
Copy link
Contributor

ue71603 commented Jun 17, 2023

The failed ones used it:

<GroupOfPlaces version="1.0" id="frst:travel_shops">

<DistributionGroupRef version="1.0" ref="frst:Travel_shops"/>

@ue71603
Copy link
Contributor

ue71603 commented Jun 17, 2023

what do you think about the latest commit?

@ue71603
Copy link
Contributor

ue71603 commented Jun 17, 2023

...at least the DistributionGroupRef is fixed...

xsd/NeTEx_publication.xsd Outdated Show resolved Hide resolved
xsd/NeTEx_publication.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 requested a review from trurlurl June 19, 2023 10:52
@@ -5170,7 +5170,7 @@ You can only get these as paper tickets, not on an Oyster card, and they must be
<DistributionChannel version="any" id="tfl:Visitor_Centres">
<Name>Visitor centres</Name>
<PaymentMethods>debitCard creditCard companyCheque cash</PaymentMethods>
<DistributionGroupRef version="any" ref="nr:Visitor_Centres"/>
<DistributionGroupRef version="any" ref="tfl:Visitor_Centres"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want the DistributionGroup to have the exact same Id as the DistributionChannel !!!?? That will not work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked fined. There is no nr:Visitor_Centers that could be referenced. And the id are per class so it works as well. The id references the GeneralGroupOfEntities (and there is only tfl:Visitor_Centres):
<GeneralGroupOfEntities version="any" id="tfl:Visitor_Centres" nameOfMemberClass="AccessSpace"> <Name>List of visitor centres</Name> <members> <AccessSpaceRef version="1" ref="tfl:Piccadilly_Circus_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Euston_Station_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Victoria_Station_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Heathrow_Terminal_123_Visitor_Centre"/> </members> </GeneralGroupOfEntities>

it does not reference to the DistributionChannel:
<DistributionChannel version="any" id="tfl:Visitor_Centres"> <Name>Visitor centres</Name> <PaymentMethods>debitCard creditCard companyCheque cash</PaymentMethods> <DistributionGroupRef version="any" ref="tfl:Visitor_Centres"/> </DistributionChannel>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lost here: in this example tfl:Visitor_Centres is the id of the DistributionChannel <DistributionChannel version="any" id="tfl:Visitor_Centres"> that has an element refering itself as a DistributionGroup ! I don't get the semantinc, neither the technical side of it !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige This is no my example. I just made it working. That the DistributionChannel and the Group used the same id text I don't know. Who knows? @nick-knowles ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact it was ok with a different namespace, but changing the namespace to "tfl" create an inconsistency !

@ue71603
Copy link
Contributor

ue71603 commented Jun 21, 2023

My fault, but: It was only ok, because no "version" was defined. With a version it no longer validated. And the other GroupofEntities was not in existance. So I used the one that was there.

@ue71603 ue71603 added this to the netex_1.2 milestone Dec 1, 2023
@ue71603 ue71603 assigned Aurige and unassigned skinkie Dec 16, 2023
@skinkie skinkie merged commit ff044de into master Feb 19, 2024
@skinkie skinkie deleted the fix_distributiongroupref branch February 19, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DistributionGroupRef is not prefixing an explicit namespace
4 participants