Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining layout issues June #593

Closed
shawaj opened this issue Jun 6, 2023 · 18 comments
Closed

Remaining layout issues June #593

shawaj opened this issue Jun 6, 2023 · 18 comments
Assignees
@Louisreed

Comments

@shawaj
Copy link
Member

shawaj commented Jun 6, 2023

Ip Addresses not obviously separated...

Screenshot_20230605_004631_Chrome

Footer still missing on small screen / mobile...

Screenshot_20230605_004228_Chrome

Side nav auto closes if you scroll down...

Screen_Recording_20230606_124233_Chrome.mp4
@shawaj
Copy link
Member Author

shawaj commented Jun 6, 2023 •
edited
Loading

Meta theme colour removed since hyper update...

Fixed by #594

@shawaj
Copy link
Member Author

shawaj commented Jun 6, 2023

Large amount of empty space between content and footer on small screens...
Screenshot_20230605_004631_Chrome
Screenshot_20230605_004348_Chrome
Screenshot_20230605_004246_Chrome

@shawaj
Copy link
Member Author

shawaj commented Jun 6, 2023

@KevinWassermann94 @WayneNebra @robputt crack any layout issues you find in the new diagnostics in here for @Louisreed

@shawaj shawaj mentioned this issue Jun 6, 2023
Closed
@shawaj
Copy link
Member Author

shawaj commented Jun 6, 2023

Should add dark theme as per #475

@shawaj shawaj changed the title Remaining layout issues Remaining layout issues June Jun 6, 2023
@shawaj
Copy link
Member Author

shawaj commented Jun 7, 2023

helium serial spills over edge of container...
image

@shawaj
Copy link
Member Author

shawaj commented Jun 7, 2023

We should also fix #573 as part of this too...
Screenshot 2023-06-07 at 18 11 38

@shawaj
Copy link
Member Author

shawaj commented Jun 8, 2023

Also on upgrade page, the button is an odd colour and the whole thing is not responsive and does not fit smallish windows...
image

@Louisreed
Copy link
Contributor

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

@Louisreed
Copy link
Contributor

Unable to reproduce 'Side nav auto closes if you scroll down' error. Will require further testing on more devices. @shawaj is this just with chrome on Android?

@shawaj
Copy link
Member Author

shawaj commented Jun 8, 2023

@Louisreed I've only tried on Chrome on Android on s23 ultra.

I can try on a different browser

Not sure if anyone has an iPhone to test with

@WayneNebra
Copy link

Same for me on an Android Oppo.

Record_2023-06-08-16-57-55.mp4

@Louisreed
Copy link
Contributor

Strange! I'll have to try with other devices. I have an iPad so will test on there as well.

@shawaj
Copy link
Member Author

shawaj commented Jun 8, 2023 •
edited
Loading

Same issue in iPhone 13 pro safari @Louisreed https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1686242502586949

@shawaj
Copy link
Member Author

shawaj commented Jun 8, 2023

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

@Louisreed can they be split out using JS or something? As presumably they have got spaces between them?

@Louisreed
Copy link
Contributor

Issue resolved!

@Louisreed
Copy link
Contributor

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

@Louisreed can they be split out using JS or something? As presumably they have got spaces between them?

Yeah I thought about using split() but would be better if I could directly access each IP. I'll see what I can do.

@shawaj
Copy link
Member Author

shawaj commented Jun 9, 2023

@Louisreed ping @robputt on slack - he might know a better way to split these out in python and then just pull them in as an array or list or whatever

shawaj added a commit that referenced this issue Jun 12, 2023
@shawaj
Merge branch 'master' into #593-issues
0efda61
shawaj added a commit that referenced this issue Jun 12, 2023
@Louisreed @shawaj
#593 issues (#605)
40cbb94 
* Fixed footer not displaying on mobile

* Fixed content page length

* Fixed upgrade button color

* Added multi-mining

* Fixed padding

* Fixed sidenav scroll bug

* Fixed table overflow

* Updated device info data, separated IP addresses

* Fixed table data alignment

* Updated helium info page to match new data badges

* Updated IP address to loop, made images static

* Updated filename

* Change for loop > for-of

* Updated thingsix address fields

---------

Co-authored-by: Aaron Shaw <shawaj@gmail.com>
shawaj added a commit that referenced this issue Jun 22, 2023
@shawaj
Merge pull request #615 from NebraLtd/#593-issues-2
c772ee8 
#593 Sidenav scroll fix
Louisreed added a commit that referenced this issue Jun 23, 2023
@Louisreed
Merge branch 'master' of https://github.com/NebraLtd/hm-diag into #593-…
66d1135 
…issues-3
shawaj added a commit that referenced this issue Jun 23, 2023
@shawaj
Merge pull request #616 from NebraLtd/#593-issues-3
17268b2 
Updated gitignore
@shawaj
Copy link
Member Author

shawaj commented Jun 24, 2023

Closed by #608 #615 #616

@shawaj shawaj closed this as completed Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Louisreed Louisreed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shawaj @Louisreed @WayneNebra