#593 Sidenav scroll fix #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawaj
reviewed
Jun 20, 2023
|
@Louisreed can you fix the sonar bug and code smells? |
|
@shawaj Should be good to go |
shawaj
reviewed
Jun 20, 2023
|
Also we need to update MANIFEST.in with the new locations of the fonts and the removed stylesheets https://github.com/NebraLtd/hm-diag/blob/%23593-issues-2/MANIFEST.in |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@shawaj Done |
shawaj
approved these changes
Jun 22, 2023
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
How
Screenshots
References
Checklist