Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thix: fix inconsistent naming and layouts #619

Merged
merged 1 commit into from
Jun 26, 2023
Merged

thix: fix inconsistent naming and layouts #619

merged 1 commit into from
Jun 26, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jun 25, 2023 •
edited
Loading

fix inconsistent naming and layouts
https://app.thingsix.com/gateways/0xacebb1738e06d7466a7317279756ac7af5c18cb466bbc8bc249458e97c6617cc

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj marked this pull request as ready for review June 26, 2023 18:39
@shawaj shawaj requested review from a team as code owners June 26, 2023 18:39
@shawaj
thix: fix inconsistent naming and layouts
57a9f12 
fix inconsistent naming and layouts
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj merged commit e09f214 into master Jun 26, 2023
@shawaj shawaj deleted the shawaj/thixfix branch June 26, 2023 18:57
shawaj added a commit to NebraLtd/helium-miner-software that referenced this pull request Jun 26, 2023
@shawaj
Bump diagnostics
63b3a49 
Refs:
NebraLtd/hm-diag#623
NebraLtd/hm-diag#619
NebraLtd/hm-diag#617
NebraLtd/hm-pyhelper#269
@shawaj shawaj mentioned this pull request Jun 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robputt robputt robputt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawaj @robputt