Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show error page when trying to claim on dashboard and using balenacloud #623

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jun 26, 2023

  • add check for nebra fleets
  • if not in nebra fleet (i.e. running on balenacloud or own openbalena instance) then when clicking claim on dashboard it goes to a specific error page

Closes: #618

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

…enacloud

- add check for nebra fleets
- if not in nebra fleet (i.e. running on balenacloud or own openbalena instance) then when clicking claim on dashboard it goes to a specific error page

Closes: #618
@shawaj shawaj marked this pull request as ready for review June 26, 2023 21:40
@shawaj shawaj requested review from a team as code owners June 26, 2023 21:40
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj merged commit 9309538 into master Jun 26, 2023
@shawaj shawaj deleted the shawaj/nebrafleet branch June 26, 2023 21:57
shawaj added a commit to NebraLtd/helium-miner-software that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When not on Nebra OpenFleet, claim on dashboard page should have error
2 participants