Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a key per account type #41

Closed
Nef10 opened this issue Jun 3, 2021 · 1 comment · Fixed by #81
Closed

Allow specifying a key per account type #41

Nef10 opened this issue Jun 3, 2021 · 1 comment · Fixed by #81
Labels
feature New feature

Comments

@Nef10
Copy link
Owner

Nef10 commented Jun 3, 2021

Currently the keys are applied to all account types:

wealthsimple-key: "contribution deposit withdrawal wealthsimple payments transfer out"
wealthsimple-account-type: "ca_tfsa ca_rrsp ca_non_registered ca_cash"

There might be use cases where one wants to separate the keys per account type.

Downside is this would be a breaking change.
@Nef10 Nef10 added question Further information or discussion is required feature New feature labels Jun 3, 2021
@Nef10 Nef10 removed the question Further information or discussion is required label Sep 17, 2021
@Nef10
Copy link
Owner Author

Nef10 commented Sep 17, 2021

Use something like wealthsimple-contribution: "AccountNumer1 AccountNumer2"

Nef10 added a commit that referenced this issue Sep 19, 2021
@Nef10
Adjust account meta data to allow specifying separately per account
1e14187 
Currently the keys are applied to all account types. This change
refactors the meta data handling, so that for every type the
Wealthsimple accounts can be set separately.
It also now only requires one entry if an account is only used for one
type.

To see how to apply meta data now, see the readme.

Fixes #41
@Nef10 Nef10 mentioned this issue Sep 19, 2021
Merged
@Nef10 Nef10 closed this as completed in #81 Sep 19, 2021
Nef10 added a commit that referenced this issue Sep 19, 2021
@Nef10
Adjust account meta data to allow specifying separately per account
d663161 
Currently the keys are applied to all account types. This change
refactors the meta data handling, so that for every type the
Wealthsimple accounts can be set separately.
It also now only requires one entry if an account is only used for one
type.

To see how to apply meta data now, see the readme.

Fixes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
1 participant
@Nef10