Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust account meta data to allow specifying separately per account #81

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

Nef10
Copy link
Owner

@Nef10 Nef10 commented Sep 19, 2021

Currently the keys are applied to all account types. This change
refactors the meta data handling, so that for every type the
Wealthsimple accounts can be set separately.
It also now only requires one entry if an account is only used for one
type.

To see how to apply meta data now, see the readme.

Fixes #41

Currently the keys are applied to all account types. This change
refactors the meta data handling, so that for every type the
Wealthsimple accounts can be set separately.
It also now only requires one entry if an account is only used for one
type.

To see how to apply meta data now, see the readme.

Fixes #41
@Nef10 Nef10 added the enhancement Improvement to an existing feature label Sep 19, 2021
@github-actions
Copy link

Coverage after merging metadata into main

34.95%

Coverage Report
FileStmtsFuncsLinesUncovered Lines
Sources/SwiftBeanCountWealthsimpleMapper
   LedgerLookup.swift84.80%90.91%83.50%66–72, 74–83
   WealthsimpleConversionError.swift100%100%100%
   WealthsimpleLedgerMapper.swift0%0%0%100–112, 126–161, 170–182, 185–216, 218–225, 227–232, 234–249, 25, 251–257, 259, 26, 260–269, 27, 270–271, 273–279, 28, 281–288, 29, 291–299, 30, 301–307, 309, 31, 310–313, 34–37, 40–44, 47–51, 58, 62–64, 78–99
   WealthsimpleTransactionRepresentable.swift100%100%100%
Sources/SwiftBeanCountWealthsimpleMapper/Extensions
   Amount+init.swift100%100%100%
   String+KebabCase.swift100%100%100%

@Nef10 Nef10 merged commit d663161 into main Sep 19, 2021
@Nef10 Nef10 deleted the metadata branch September 19, 2021 01:42
@Nef10 Nef10 added the minor This change should bump the minor version of the next release label Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature minor This change should bump the minor version of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying a key per account type
1 participant