Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash for SparsePoly #1691

Closed
wants to merge 1 commit into from

Conversation

lgoettgens
Copy link
Collaborator

Resolves one issue described in #1689.

Note that this still not fulfils the contract that == objects have the same hash due to the ad-hoc comparisons to the base ring and to Int etc. But since this is the same case for "normal" polys, I would ignore this.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.90%. Comparing base (9c828f7) to head (a7ee78f).
Report is 1 commits behind head on master.

Files Patch % Lines
src/generic/SparsePoly.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   87.34%   86.90%   -0.45%     
==========================================
  Files         116      116              
  Lines       29713    29693      -20     
==========================================
- Hits        25954    25805     -149     
- Misses       3759     3888     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens deleted the lg/sparsepoly-hash branch April 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant