Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for SparsePolyRing #1692

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Fixes for SparsePolyRing #1692

merged 5 commits into from
Apr 26, 2024

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Apr 26, 2024

Contains and thus closes #1691.

Contents:

@lgoettgens lgoettgens force-pushed the lg/sparse branch 2 times, most recently from 560e9c3 to d2dcb61 Compare April 26, 2024 11:58
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 85.91%. Comparing base (9c828f7) to head (89003c5).
Report is 1 commits behind head on master.

Files Patch % Lines
src/generic/SparsePoly.jl 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   87.34%   85.91%   -1.44%     
==========================================
  Files         116      116              
  Lines       29713    29736      +23     
==========================================
- Hits        25954    25548     -406     
- Misses       3759     4188     +429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens changed the title Fix coeff for sparse polys and more feature parity Fixes for SparsePolyRing Apr 26, 2024
@lgoettgens lgoettgens marked this pull request as ready for review April 26, 2024 12:41
@fingolfin fingolfin enabled auto-merge (squash) April 26, 2024 13:23
@fingolfin fingolfin merged commit 86a9299 into Nemocas:master Apr 26, 2024
29 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/sparse branch April 26, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants