-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for SparsePolyRing #1692
Merged
Merged
Fixes for SparsePolyRing #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/sparse
branch
2 times, most recently
from
April 26, 2024 11:58
560e9c3
to
d2dcb61
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
- Coverage 87.34% 85.91% -1.44%
==========================================
Files 116 116
Lines 29713 29736 +23
==========================================
- Hits 25954 25548 -406
- Misses 3759 4188 +429 ☔ View full report in Codecov by Sentry. |
lgoettgens
changed the title
Fix coeff for sparse polys and more feature parity
Fixes for SparsePolyRing
Apr 26, 2024
thofma
approved these changes
Apr 26, 2024
fingolfin
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains and thus closes #1691.
Contents:
Generic.SparsePoly
#1689SparsePolynomialRing
(technically breaking)