Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Investigate struct ordening u256 in Cairo and Native/Blockifier #97

Closed
xrvdg opened this issue Jun 28, 2024 · 2 comments · Fixed by #110
Closed

Investigate struct ordening u256 in Cairo and Native/Blockifier #97

xrvdg opened this issue Jun 28, 2024 · 2 comments · Fixed by #110
Assignees

Comments

@xrvdg
Copy link

xrvdg commented Jun 28, 2024

Accessing the high part of a U256 from within Rust gives the same result as accessing the low part of u256 from within Cairo. This seems to point to the order of the struct getting mixed up. We currently workaround this in both keccak and secp in the native starknet sycall handler.

@xrvdg xrvdg self-assigned this Jun 28, 2024
@xrvdg
Copy link
Author

xrvdg commented Jul 3, 2024

Opened a ticket for it on the cairo native repo: lambdaclass/cairo_native#715

@xrvdg
Copy link
Author

xrvdg commented Jul 9, 2024

This has been fixed in lambdaclass/cairo_native#720.

We need to update our keccak and secp when bumping our dependency on cairo native to a commit after lambdaclass/cairo_native@9527cc9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant