-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cairo_native swaps the high and low fields of U256 compared to Cairo's u256 #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
July 5, 2024 13:19
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.300 ± 0.063 | 11.234 | 11.425 | 23.46 ± 0.26 |
cairo-native (embedded AOT) |
1.541 ± 0.010 | 1.522 | 1.554 | 3.20 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.617 ± 0.009 | 1.605 | 1.632 | 3.36 ± 0.04 |
cairo-native (standalone AOT) |
0.654 ± 0.002 | 0.651 | 0.656 | 1.36 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.482 ± 0.005 | 0.480 | 0.495 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.726 ± 0.030 | 10.686 | 10.774 | 1317.98 ± 23.74 |
cairo-native (embedded AOT) |
1.110 ± 0.006 | 1.103 | 1.123 | 136.35 ± 2.53 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.118 ± 0.003 | 1.111 | 1.123 | 137.40 ± 2.48 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.012 | 1.04 ± 0.03 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.010 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.909 ± 0.013 | 1.893 | 1.937 | 28.88 ± 0.21 |
cairo-native (embedded AOT) |
1.257 ± 0.006 | 1.251 | 1.266 | 19.01 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.431 ± 0.013 | 1.414 | 1.451 | 21.64 ± 0.20 |
cairo-native (standalone AOT) |
0.107 ± 0.000 | 0.107 | 0.107 | 1.62 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.066 ± 0.000 | 0.066 | 0.066 | 1.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 118 118
Lines 32644 32644
=======================================
Hits 29931 29931
Misses 2713 2713 ☔ View full report in Codecov by Sentry. |
azteca1998
previously approved these changes
Jul 5, 2024
juanbono
previously approved these changes
Jul 8, 2024
pefontana
previously approved these changes
Jul 8, 2024
pefontana
approved these changes
Jul 8, 2024
juanbono
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
I introduced this when i added the corelib tests, instead of changing the field order of the u256, instead i swapped the tests and starknet syscall impl, but that was wrong, now its fixed
Checklist