This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
fix: remove U256 workarounds #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## native2.6.4 #110 +/- ##
===============================================
- Coverage 80.63% 80.62% -0.02%
===============================================
Files 77 77
Lines 10587 10579 -8
Branches 10587 10579 -8
===============================================
- Hits 8537 8529 -8
Misses 1584 1584
Partials 466 466 ☔ View full report in Codecov by Sentry. |
varex83
approved these changes
Jul 16, 2024
| @@ -577,8 +577,8 @@ impl<'state> StarknetSyscallHandler for &mut NativeSyscallHandler<'state> { | |||
| } | |||
|
|
|||
| Ok(U256 { | |||
| lo: u128::from(state[2]) | (u128::from(state[3]) << 64), | |||
| hi: u128::from(state[0]) | (u128::from(state[1]) << 64), | |||
| hi: u128::from(state[2]) | (u128::from(state[3]) << 64), | |||
There was a problem hiding this comment.
nitpick: let's keep it in order lo: ..., hi:....
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #97
Cairo native has fixed the byte order of U256 and in this PR we incorporate the fix and remove our workaround.