This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to Contract writer
CairoAssert node is an expression, hence it appears as a statement only as a child of ExpressionStatement. The writer for this node already adds the semicolon.
piwonskp
commented
Mar 10, 2023
piwonskp
commented
Mar 10, 2023
piwonskp
commented
Mar 10, 2023
piwonskp
commented
Mar 16, 2023
rodrigo-pino
approved these changes
Mar 20, 2023
* Get rid of hashbuiltin * Fix WARP_USED_STORAGE * Cleanup * Fix WARP_NAMEGEN * Fix storage consts * Fix LegacyMap issues * Fix uint256 serialization and construction * Add missing condition * Fix structs serialization * Change `get_caller_address`path * Transform `get_caller_address` output to felt * Remove unused import * Warplib import (#985) * create u256 from 2 felts (#975) * proposed sol: warplib import * Add warplib::integer to corelib * Add warplib::integer to x64 * Add integer functions to warplib.cairo --------- Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com> Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> Co-authored-by: Piotr Piwoński <piwonskp> * Revert using `::` in generated functions not ported to cairo 1 yet * Revert `WARP_USED_STORAGE::` in cairo 0.x scripts * Remove unused import * follow import convention * Fix warplib errors * Add missing math imports to arm warplib.cairo * Rename UINT256 to GET_U128 * Create ADDRESS_INTO_FELT import directly * Revert "Create ADDRESS_INTO_FELT import directly" This reverts commit f388dc6. * Replace `get_u128_try_from_felt_result` with corelib implementation * Add newlines --------- Co-authored-by: Piotr Piwoński <piwonskp> Co-authored-by: Rohit Ranjan <rohitrjn629@gmail.com> Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com>
This was referenced Mar 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.