This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Warplib import #985
Merged
Warplib import #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rjnrohit
force-pushed
the
warplib_import
branch
from
67af8d6
to
ad8f82b
Compare
done |
piwonskp
approved these changes
Mar 10, 2023
rodrigo-pino
approved these changes
Mar 10, 2023
piwonskp
added a commit
that referenced
this pull request
Mar 20, 2023
* Get rid of hashbuiltin * Fix WARP_USED_STORAGE * Cleanup * Fix WARP_NAMEGEN * Fix storage consts * Fix LegacyMap issues * Fix uint256 serialization and construction * Add missing condition * Fix structs serialization * Change `get_caller_address`path * Transform `get_caller_address` output to felt * Remove unused import * Warplib import (#985) * create u256 from 2 felts (#975) * proposed sol: warplib import * Add warplib::integer to corelib * Add warplib::integer to x64 * Add integer functions to warplib.cairo --------- Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com> Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> Co-authored-by: Piotr Piwoński <piwonskp> * Revert using `::` in generated functions not ported to cairo 1 yet * Revert `WARP_USED_STORAGE::` in cairo 0.x scripts * Remove unused import * follow import convention * Fix warplib errors * Add missing math imports to arm warplib.cairo * Rename UINT256 to GET_U128 * Create ADDRESS_INTO_FELT import directly * Revert "Create ADDRESS_INTO_FELT import directly" This reverts commit f388dc6. * Replace `get_u128_try_from_felt_result` with corelib implementation * Add newlines --------- Co-authored-by: Piotr Piwoński <piwonskp> Co-authored-by: Rohit Ranjan <rohitrjn629@gmail.com> Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com>
piwonskp
added a commit
that referenced
this pull request
Mar 20, 2023
* update assert writer * update assignment writer * update variable declaration statement writer * update return writer * support member access for values and namespaces * remove Uint256 warp structure from literal writer * use expression as condition in if statement writer * update expression statement writer * update event definition writer * update cairo function definition writer * update tempvar writer to just use let * move imports, util funcs, const and structs definition from SourceUnit to Contract writer * convert felts to uint * create u256 from 2 felts * use u256_from_felts to create u256 values * Fix linting errors * add import to get u256 from felts * add missing semicolon at the end of imports * remove unnecessary semicolon in cairoAssert CairoAssert node is an expression, hence it appears as a statement only as a child of ExpressionStatement. The writer for this node already adds the semicolon. * fix typo in mapping generated info * fix assertion error messsage * rename cairo1 binary for linux folder * no need to replace identifiers with contract member access * remove unused import and spaces * fix decorators style * Erc20 storage fixes (#979) * Get rid of hashbuiltin * Fix WARP_USED_STORAGE * Cleanup * Fix WARP_NAMEGEN * Fix storage consts * Fix LegacyMap issues * Fix uint256 serialization and construction * Add missing condition * Fix structs serialization * Change `get_caller_address`path * Transform `get_caller_address` output to felt * Remove unused import * Warplib import (#985) * create u256 from 2 felts (#975) * proposed sol: warplib import * Add warplib::integer to corelib * Add warplib::integer to x64 * Add integer functions to warplib.cairo --------- Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com> Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> Co-authored-by: Piotr Piwoński <piwonskp> * Revert using `::` in generated functions not ported to cairo 1 yet * Revert `WARP_USED_STORAGE::` in cairo 0.x scripts * Remove unused import * follow import convention * Fix warplib errors * Add missing math imports to arm warplib.cairo * Rename UINT256 to GET_U128 * Create ADDRESS_INTO_FELT import directly * Revert "Create ADDRESS_INTO_FELT import directly" This reverts commit f388dc6. * Replace `get_u128_try_from_felt_result` with corelib implementation * Add newlines --------- Co-authored-by: Piotr Piwoński <piwonskp> Co-authored-by: Rohit Ranjan <rohitrjn629@gmail.com> Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com> --------- Co-authored-by: AlejandroLabourdette <jal.labourdette@gmail.com> Co-authored-by: Carmen Cabrera <kr1000a@gmail.com> Co-authored-by: Rohit Ranjan <rohitrjn629@gmail.com> Co-authored-by: Alejandro Labourdette <66191544+AlejandroLabourdette@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to warplib import issue