Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workaround for downloading artifacts in CentOS 7 #614

Closed
wants to merge 1 commit into from

Conversation

derevnjuk
Copy link
Member

No description provided.

@derevnjuk derevnjuk added the Type: ci Pull requests that update CI/CD workflows label Nov 15, 2024
@derevnjuk derevnjuk self-assigned this Nov 15, 2024
@derevnjuk derevnjuk force-pushed the build/force-actions-use-node-16 branch 6 times, most recently from a5369ff to 9abc3cb Compare November 15, 2024 10:39
@derevnjuk derevnjuk changed the title ci: force GitHub Actions use Node v16 ci: workaround for downloading artifacts in CentOS 7 Nov 15, 2024
@derevnjuk derevnjuk force-pushed the build/force-actions-use-node-16 branch from 9abc3cb to 67e2874 Compare November 15, 2024 10:49
@derevnjuk
Copy link
Member Author

derevnjuk commented Nov 15, 2024

We are in troubles as actions/upload-artifact@v3 and actions/download-artifact@v3 will be deprecated by the end of November (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). The new versions require Nodejs 20, which depends on glibc 2.25+, not available in CentOS 7.

Also, Nodejs 16 will also be removed from runner images in a few days (actions/runner-images#10896), breaking workflows that use actions/checkout@v3. This will also make workarounds like ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION unusable.

There doesn’t seem to be a quick or easy workaround. We might drop support for RHEL7, but it is still in Extended Life Support (ELS) until 2028 🤯 (https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance?cicd=32h281b)

So, seems our workflows will die on November 18

@orubin @bararchy fyi

@derevnjuk derevnjuk closed this Nov 15, 2024
@derevnjuk derevnjuk deleted the build/force-actions-use-node-16 branch November 15, 2024 11:12
@orubin
Copy link
Contributor

orubin commented Nov 24, 2024

We are in troubles as actions/upload-artifact@v3 and actions/download-artifact@v3 will be deprecated by the end of November (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). The new versions require Nodejs 20, which depends on glibc 2.25+, not available in CentOS 7.

Also, Nodejs 16 will also be removed from runner images in a few days (actions/runner-images#10896), breaking workflows that use actions/checkout@v3. This will also make workarounds like ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION unusable.

There doesn’t seem to be a quick or easy workaround. We might drop support for RHEL7, but it is still in Extended Life Support (ELS) until 2028 🤯 (https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance?cicd=32h281b)

So, seems our workflows will die on November 18

@orubin @bararchy fyi

Thanks @derevnjuk - accordinfg to the the github changlog:
"Starting December 5, 2024, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact."

So we have until 05.12.2024?
FYI @adirdidi

@bramkor
Copy link
Contributor

bramkor commented Nov 24, 2024

@derevnjuk According to Adir the customers using RHEL 7 can use v12 repeater/cli.
The v13 repeater -coming out soon - will not support CentOS7/RHEL7.
Does it mean we can move forward with this PR or are there other things that need to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: ci Pull requests that update CI/CD workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants