Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade github artifact actions to v4 #615

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

bramkor
Copy link
Contributor

@bramkor bramkor commented Nov 19, 2024

Update the GitHub Action upload-artifact from version 3 to version 4. The upgrade provides enhanced artifact handling, and compatibility with the latest GitHub Actions runtime features.

@bramkor bramkor self-assigned this Nov 19, 2024
@bramkor bramkor added Status: wip The PR is a WIP. Type: tooling The issues that touch on the build system, linting, test tooling labels Nov 19, 2024
@bramkor bramkor changed the title feat(bright-cli): upgrade github artifact actions to v4 ci(bright-cli): upgrade github artifact actions to v4 Nov 19, 2024
@derevnjuk
Copy link
Member

This won’t work with the current setup: #614 (comment)

@derevnjuk derevnjuk changed the title ci(bright-cli): upgrade github artifact actions to v4 ci: upgrade github artifact actions to v4 Nov 25, 2024
@derevnjuk
Copy link
Member

derevnjuk commented Nov 25, 2024

@bramkor since we will no longer support RHAT7/CentOS7, please use redhat/ubi8 instead of centos/devtoolset-7-toolchain-centos7 image, as it includes the required GLIBC/GCC versions.

@orubin orubin requested a review from derevnjuk November 26, 2024 10:35
@orubin orubin added Type: ci Pull requests that update CI/CD workflows and removed Status: wip The PR is a WIP. labels Nov 26, 2024
@derevnjuk derevnjuk enabled auto-merge (squash) November 26, 2024 15:23
@derevnjuk derevnjuk merged commit 37dd4df into master Nov 26, 2024
6 checks passed
@derevnjuk derevnjuk deleted the feat/upgrade-upload-artifact branch November 26, 2024 15:23
@derevnjuk
Copy link
Member

derevnjuk commented Nov 26, 2024

@bramkor please ensure that all future PRs (ofc except maintenance and hotfixes) are opened against the next branch

@orubin fyi

@bramkor
Copy link
Contributor Author

bramkor commented Nov 27, 2024

@derevnjuk @orubin note taken, thanks.
Or I asked in our group if I should open against master or next, and was told to open against master. Let's make sure we are all aligned.

@derevnjuk
Copy link
Member

derevnjuk commented Nov 27, 2024

image @bramkor, please port your changes to the appropriate branch. You can simple merge master into next as follow:
git fetch --refetch -p -P
git pull --force --rebase
git checkout next
git pull --force --rebase
git merge --no-ff master
git push

@orubin
Copy link
Contributor

orubin commented Nov 27, 2024

Thanks @derevnjuk

I guess you meant git merge --no-ff master one line before the last.

Right?

@derevnjuk
Copy link
Member

@orubin yes, thanks 👍🏾

@derevnjuk
Copy link
Member

@orubin workflow is still failing (e.g. https://github.com/NeuraLegion/bright-cli/actions/runs/12128761278/job/33815969270). After migrating to ubi8, you should replace yum with microdnf.

@orubin
Copy link
Contributor

orubin commented Dec 3, 2024

@orubin workflow is still failing (e.g. https://github.com/NeuraLegion/bright-cli/actions/runs/12128761278/job/33815969270). After migrating to ubi8, you should replace yum with microdnf.

Thanks @derevnjuk - noted and appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: ci Pull requests that update CI/CD workflows Type: tooling The issues that touch on the build system, linting, test tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants