Adding device verification to user profile #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
2 times, most recently
from
d1b5365 to
92f67a2
Compare
auscompgeek
reviewed
May 26, 2020
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
3 times, most recently
from
dfa1571 to
208d89b
Compare
deepbluev7
reviewed
Jun 1, 2020
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
from
208d89b to
621ad4c
Compare
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
2 times, most recently
from
6479a12 to
9bfc9b8
Compare
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
from
9bfc9b8 to
bbaf15b
Compare
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
from
614ad76 to
33c13ee
Compare
deepbluev7
reviewed
Jun 23, 2020
- DeviceVerificationList change to LinkedList to improve time
complexity while deleting
- Downgrade the flow to not use key.verification.done and
key.verification.ready
|
This needs some more spacing and the username :3 |
That's weird I get the username, maybe a issue of theming, and what spacing were you mentioning? |
deepbluev7
reviewed
Jun 24, 2020
|
Yeah, it seems like in general the palette doesn't apply correctly on my system. I noticed that I had quite a few labels, where I needed to set the color manually. The spacing is simply that the OK button has no padding in the corner and the scrollbar overlaps with the verify buttons |
|
I do get these quite a lot: qrc:/qml/UserProfile.qml:144:21: Unable to assign [undefined] to QColor (qrc:/qml/UserProfile.qml:144, ) |
deepbluev7
reviewed
Jun 24, 2020
deepbluev7
reviewed
Jun 24, 2020
deepbluev7
reviewed
Jun 24, 2020
- remove unnecessary field sender in userprofile.qml
- cover user facing string with qsTr to get picked by translations
- add spacing and fix theming issue
- increase and add color to username
- change back to QVector from QLinkedList cause I have mistaken
better time complexity to give better benchmark
red
deepbluev7
reviewed
Jun 24, 2020
deepbluev7
reviewed
Jul 1, 2020
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
3 times, most recently
from
0181bb9 to
5ab9562
Compare
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
from
5ab9562 to
9e3f900
Compare
Chethan2k1
force-pushed
the
device-verification-dialogs
branch
from
9093b04 to
eb80360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.