WIP: New event store #251
Merged
WIP: New event store #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issues when sending images to some clients.
Conflicts: CMakeLists.txt io.github.NhekoReborn.Nheko.json src/Cache.cpp src/timeline/TimelineModel.cpp src/timeline/TimelineModel.h src/timeline/TimelineViewManager.cpp
The loss in durability shouldn't matter, if we can just receive the same events again after a restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: https://blog.neko.dev/posts/nhekos-event-store-v2.html
This should be ready now
I'm still testing this and the migration path has not been tested that well yet (since I wiped my db by accident a few times :D).Migration may work now, but you will probably be affected by matrix-org/synapse#1602.
I also still need to document this properly and clean it up quite a bit, but all in all this should mostly work for now. This will conflict with #237 and #203. Especially regarding #237 I'm not sure how to handle that yet, since hiding events from the timeline moved to the database and in that complicates hiding call candidate events quite a bit, since it doesn't have any relations, as far as I'm aware. This may be fixable through an MSC or we need to decrypt events in the database or punch a hole from the frontend to remove those events from the display list... I'll need to solve that, before this gets merged.I'll also probably write a blogpost and document how the event store is supposed to work properly before this gets merged, but I was mostly focusing on getting this in a somewhat workable state first. (This PR is mostly for CI and so that I don't lose this, when my HDD dies or so :D)fixes #168