C++ style enums 9/N: FlexDirection (facebook#1394)

Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: e12ec756cfcca879fefc49e5596a73bd6711e87b

Yoga.podspec

@@ -46,4 +46,5 @@ Pod::Spec.new do |spec|
 
   all_header_files = 'yoga/**/*.h'
   spec.private_header_files = Dir.glob(all_header_files) - Dir.glob(public_header_files)
+  spec.preserve_paths = [all_header_files]
 end

tests/YGStyleAccessorsTest.cpp

@@ -89,10 +89,10 @@ ACCESSOR_TEST(
 
 ACCESSOR_TEST(
     flexDirection,
-    YGFlexDirectionColumn,
-    YGFlexDirectionColumnReverse,
-    YGFlexDirectionRowReverse,
-    YGFlexDirectionRow)
+    FlexDirection::Column,
+    FlexDirection::ColumnReverse,
+    FlexDirection::RowReverse,
+    FlexDirection::Row)
 
 ACCESSOR_TEST(
     justifyContent,

yoga/Yoga.cpp

@@ -439,10 +439,10 @@ void YGNodeStyleSetFlexDirection(
     const YGNodeRef node,
     const YGFlexDirection flexDirection) {
   updateStyle<MSVC_HINT(flexDirection)>(
-      node, &Style::flexDirection, flexDirection);
+      node, &Style::flexDirection, scopedEnum(flexDirection));
 }
 YGFlexDirection YGNodeStyleGetFlexDirection(const YGNodeConstRef node) {
-  return resolveRef(node)->getStyle().flexDirection();
+  return unscopedEnum(resolveRef(node)->getStyle().flexDirection());
 }
 
 void YGNodeStyleSetJustifyContent(

yoga/algorithm/BoundAxis.h

@@ -9,6 +9,7 @@
 
 #include <yoga/algorithm/FlexDirection.h>
 #include <yoga/algorithm/ResolveValue.h>
+#include <yoga/enums/FlexDirection.h>
 #include <yoga/node/Node.h>
 #include <yoga/numeric/Comparison.h>
 #include <yoga/numeric/FloatOptional.h>
@@ -17,7 +18,7 @@ namespace facebook::yoga {
 
 inline float paddingAndBorderForAxis(
     const yoga::Node* const node,
-    const YGFlexDirection axis,
+    const FlexDirection axis,
     const float widthSize) {
   return (node->getLeadingPaddingAndBorder(axis, widthSize) +
           node->getTrailingPaddingAndBorder(axis, widthSize))
@@ -26,7 +27,7 @@ inline float paddingAndBorderForAxis(
 
 inline FloatOptional boundAxisWithinMinAndMax(
     const yoga::Node* const node,
-    const YGFlexDirection axis,
+    const FlexDirection axis,
     const FloatOptional value,
     const float axisSize) {
   FloatOptional min;
@@ -59,7 +60,7 @@ inline FloatOptional boundAxisWithinMinAndMax(
 // go below the padding and border amount.
 inline float boundAxis(
     const yoga::Node* const node,
-    const YGFlexDirection axis,
+    const FlexDirection axis,
     const float value,
     const float axisSize,
     const float widthSize) {