Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyaml-cpp: Fix wrong paths in pkg-config .pc file. #144169

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 2, 2021

Motivation for this change

Same as in #71669 and #81091 and 029c3f9.

See #144170 for the general issue.

Before this fix:

NIX_PATH=nixpkgs=. nix-shell -p libyamlcpp -p pkg-config --run 'pkg-config --cflags yaml-cpp'
-I/nix/store/bq106wng1cqk8r4y1y7yh5h7cz49jxpv-libyaml-cpp-0.7.0//nix/store/bq106wng1cqk8r4y1y7yh5h7cz49jxpv-libyaml-cpp-0.7.0/include

With this fix, the path is correct:

NIX_PATH=nixpkgs=. nix-shell -p libyamlcpp -p pkg-config --run 'pkg-config --cflags yaml-cpp'
-I/nix/store/9hwyd6im206isapba0i8gyc5i3g1df2j-libyaml-cpp-0.7.0/include
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
Copy link
Contributor

r-burns commented Nov 2, 2021

I would suggest filing an upstream issue for this and pointing them to https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files

@r-burns
Copy link
Contributor

r-burns commented Nov 3, 2021

I opened an upstream PR for this: jbeder/yaml-cpp#1058

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 11, 2021

Can we fetch the patch instead?

@nh2
Copy link
Contributor Author

nh2 commented Nov 18, 2021

Can we fetch the patch instead?

Done.

Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-linux. Thanks!

@nh2 nh2 merged commit 5e59d57 into master Nov 19, 2021
@nh2
Copy link
Contributor Author

nh2 commented Nov 19, 2021

Btw, it would probably make sense to rename libyamlcpp to yaml-cpp in nixpkgs, and add an alias to the old one.

@r-burns
Copy link
Contributor

r-burns commented Nov 19, 2021

Repology agrees: https://repology.org/project/yaml-cpp/versions

@r-burns r-burns deleted the libyaml-cpp-fix-pc-file branch November 19, 2021 01:49
@mausch mausch mentioned this pull request Dec 7, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants