Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micromamba: fix libyamlcpp dependency #149478

Merged
merged 1 commit into from
Dec 10, 2021
Merged

micromamba: fix libyamlcpp dependency #149478

merged 1 commit into from
Dec 10, 2021

Conversation

mausch
Copy link
Member

@mausch mausch commented Dec 7, 2021

Motivation for this change

Fix micromamba package. Reported broken in https://discourse.nixos.org/t/fix-broken-micromamba-fhs-environment/16460 .
This basically reverts #144169 for this private libyamlcpp dependency.
Hopefully when we upgrade micromamba it won't need this private libyamlcpp any more.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/fix-broken-micromamba-fhs-environment/16460/5

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 7, 2021
@symphorien symphorien merged commit 8af12f1 into NixOS:master Dec 10, 2021
@github-actions github-actions bot mentioned this pull request Dec 10, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #150134 for release-21.11.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

@mausch mausch deleted the micromamba-fix branch February 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mausch @nixos-discourse @symphorien