units: fix build with enableCurrenciesUpdater=false; pythonPackages=null; #182172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ull;
Units allows to build it without a python dependency by setting {
enableCurrenciesUpdater=false; pythonPackages=null; }. Unfortunately
this feature is currently broken due to two problems:
1. The `pythonEnv` string is part of the builder environment, so it is
not evaluated lazily. This means that `pythonPackages==null` will
always cause eval to fail.
2. `pythonEnv` is used unconditionally in an antiquotation in the
`prePatch` phase; if it is null this will fail.
Let's fix these so we can build a pythonless "units" package.
This is helpful when cross-compiling, because right now a lot of
python packages (especially python-cryptography) fail to
cross-compile.
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
Ping @vrthra |
|
Ping |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Units allows to build it without a python dependency by setting { enableCurrenciesUpdater=false; pythonPackages=null; }. Unfortunately this feature is currently broken due to two problems:
The
pythonEnvstring is part of the builder environment, so it is not evaluated lazily. This means thatpythonPackages==nullwill always cause eval to fail.pythonEnvis used unconditionally in an antiquotation in theprePatchphase; if it is null this will fail.Let's fix these so we can build a pythonless "units" package.
This is helpful when cross-compiling, because right now a lot of python packages (especially python-cryptography) fail to cross-compile.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)