Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units: fix build with enableCurrenciesUpdater=false; pythonPackages=null; #182172

Merged
merged 1 commit into from Apr 22, 2023
Merged

units: fix build with enableCurrenciesUpdater=false; pythonPackages=null; #182172

merged 1 commit into from Apr 22, 2023

Commits on Jul 20, 2022

  1. units: fix build with enableCurrenciesUpdater=false; pythonPackages=n…

    …ull;
    
    Units allows to build it without a python dependency by setting {
    enableCurrenciesUpdater=false; pythonPackages=null; }.  Unfortunately
    this feature is currently broken due to two problems:
    
    1. The `pythonEnv` string is part of the builder environment, so it is
       not evaluated lazily.  This means that `pythonPackages==null` will
       always cause eval to fail.
    
    2. `pythonEnv` is used unconditionally in an antiquotation in the
       `prePatch` phase; if it is null this will fail.
    
    Let's fix these so we can build a pythonless "units" package.
    
    This is helpful when cross-compiling, because right now a lot of
    python packages (especially python-cryptography) fail to
    cross-compile.
    Adam Joseph committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    3f11515 View commit details
    Browse the repository at this point in the history