Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmountains: use xorg.* packages directly instead of xlibsWrapper indi… #198225

Merged
merged 1 commit into from
Oct 29, 2022
Merged

xmountains: use xorg.* packages directly instead of xlibsWrapper indi… #198225

merged 1 commit into from
Oct 29, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 28, 2022 •
edited
Loading

…rection

Tested as no material change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
xmountains: use xorg.* packages directly instead of xlibsWrapper indi…
9579e9d 
…rection

Tested as no material change in `out` output with `diffoscope`.
@trofi trofi mentioned this pull request Oct 28, 2022
Closed
83 tasks
@ofborg ofborg bot requested a review from djanatyn October 28, 2022 07:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 28, 2022
@bjornfor bjornfor merged commit ac36151 into NixOS:master Oct 29, 2022
@trofi trofi deleted the xmountains-without-xlibsWrapper branch October 29, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@djanatyn djanatyn Awaiting requested review from djanatyn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @bjornfor